-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs-patterns): respect taskDefinition prop in QueueProcessingFargateService. #27410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
Hey, I see you have requested for an exemption. Could you tell me why integration tests are not required for this change? |
The build is also currently failing. We would not be able to prioritize reviewing this PR if the build if failing. Let me know if you have any questions. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Title: Fix for Issue #27360: taskDefinition prop ignored on QueueProcessingFargateService
Comment:
This pull request addresses the bug reported in Issue #27360. The QueueProcessingFargateService was not correctly handling the taskDefinition prop. If a taskDefinition was provided, it was being ignored and a new one was being created regardless.
Changes:
This change fixes the bug and allows the QueueProcessingFargateService to correctly use a provided taskDefinition.
Please review the changes and provide feedback.
Fixes #27360