docs(ssm): doc for grantRead in IParameter is missing GetParameters

[go-to-k]

The doc for grantRead in IParameter is missing GetParameters.

The grantRead actually grants 'ssm:GetParameters'.

    return iam.Grant.addToPrincipal({
      grantee,
      actions: [
        'ssm:DescribeParameters',
        'ssm:GetParameters',
        'ssm:GetParameter',
        'ssm:GetParameterHistory',
      ],

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ssm/lib/parameter.ts#L181-L186

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[lpizzinidev]

Nice catch 👍

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[go-to-k]

@scanlonp Thanks to approve, but the merge failed... Do you handle this again please?

Pull request has been modified.

[go-to-k]

@scanlonp

Oh... It appears that CodeBuild has failed this time. Do you know how to deal with this? Is it possible to have it run again?

aws-cdk: FAIL test/commands/migrate.test.ts (37.451 s)
aws-cdk:   笳� Migrate Function Tests 窶ｺ generateCdkApp generates the expected cdk app when called for java
aws-cdk:     thrown: "Exceeded timeout of 30000 ms for a test.
aws-cdk:     Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
aws-cdk:     �[0m �[90m 218 |�[39m�[0m
aws-cdk:     �[0m �[90m 219 |�[39m �[36mfunction�[39m cliTest(name�[33m:�[39m string�[33m,�[39m handler�[33m:�[39m (dir�[33m:�[39m string) �[33m=>�[39m �[36mvoid�[39m �[33m|�[39m �[33mPromise�[39m�[33m<�[39m�[33many�[39m�[33m>�[39m)�[33m:�[39m �[36mvoid�[39m {�[0m
aws-cdk:     �[0m�[31m�[1m>�[22m�[39m�[90m 220 |�[39m   test(name�[33m,�[39m () �[33m=>�[39m withTempDir(handler))�[33m;�[39m�[0m
aws-cdk:     �[0m �[90m     |�[39m   �[31m�[1m^�[22m�[39m�[0m
aws-cdk:     �[0m �[90m 221 |�[39m }�[0m
aws-cdk:     �[0m �[90m 222 |�[39m�[0m
aws-cdk:     �[0m �[90m 223 |�[39m �[36masync�[39m �[36mfunction�[39m withTempDir(cb�[33m:�[39m (dir�[33m:�[39m string) �[33m=>�[39m �[36mvoid�[39m �[33m|�[39m �[33mPromise�[39m�[33m<�[39m�[33many�[39m�[33m>�[39m) {�[0m
aws-cdk:       at cliTest (test/commands/migrate.test.ts:220:3)
aws-cdk:       at test/commands/migrate.test.ts:149:3
aws-cdk:       at Object.<anonymous> (test/commands/migrate.test.ts:11:1)

Pull request has been modified.

[scanlonp]

I would guess it is this change (#27870) that is now causing a java app creation test to fail. Unsure why it would pass the build there but fail here. Never mind, it was not that at all (Java =/= Go). Will check it out.
Probably a flaky test.

[go-to-k]

@scanlonp

Oh! This time the Build succeeded!
Please check it.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5a0e7a6
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).