-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): NODEJS_LATEST now points to nodejs20.x #28126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @MunchyYDL, I'm part of the CDK team and I'm unaware of any work being done on this besides you and me right here :). I'll get back to this PR today and hopefully fix the failing build, and then merge it to get you that sweet, sweet contribution! |
Hi @MunchyYDL, so I created #28171 after talking to some folks on the team. tl;dr: is that we can't move forward here until node20 exists in all regions, which hasn't happened yet. I'm going to park this PR in draft mode, and when the time comes, revive it and get it in. |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
AWS CDK v2.107.0 introduced
nodejs20.x
as a valid runtime for lambda, including the NODEJS_20_X, but the NODEJS_LATEST static still usesnodejs18.x
in the latest release (v2.110.1).This PR just adjust NODEJS_LATEST to use
nodejs20.x
instead.Closes #28125.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license