Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): NODEJS_LATEST now points to nodejs20.x #28126

Closed
wants to merge 3 commits into from

Conversation

MunchyYDL
Copy link

@MunchyYDL MunchyYDL commented Nov 24, 2023

AWS CDK v2.107.0 introduced nodejs20.x as a valid runtime for lambda, including the NODEJS_20_X, but the NODEJS_LATEST static still uses nodejs18.x in the latest release (v2.110.1).

This PR just adjust NODEJS_LATEST to use nodejs20.x instead.

Closes #28125.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 24, 2023 01:19
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Nov 24, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@MunchyYDL MunchyYDL changed the title Update NODEJS_LATEST to use nodejs20.x fix(lambda): set NODEJS_LATEST to use nodejs20.x Nov 24, 2023
@MunchyYDL MunchyYDL marked this pull request as draft November 24, 2023 02:07
@kaizencc kaizencc changed the title fix(lambda): set NODEJS_LATEST to use nodejs20.x feat(lambda): NODEJS_LATEST now points to nodejs20.x Nov 27, 2023
@kaizencc kaizencc marked this pull request as ready for review November 27, 2023 21:27
@github-actions github-actions bot added effort/medium Medium work item – several days of effort p1 and removed p2 labels Nov 27, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 27, 2023 21:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 35e7af3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@MunchyYDL
Copy link
Author

Thanks for helping out @kaizencc, I just haven't had the time to continue with this. :)
But as mentioned in the issue I opened for this, there is already some work being done on this issue, so I'm not sure that this will be merged, or maybe you are involved in that work?

#28125

@kaizencc
Copy link
Contributor

Hi @MunchyYDL, I'm part of the CDK team and I'm unaware of any work being done on this besides you and me right here :). I'll get back to this PR today and hopefully fix the failing build, and then merge it to get you that sweet, sweet contribution!

@kaizencc
Copy link
Contributor

Hi @MunchyYDL, so I created #28171 after talking to some folks on the team. tl;dr: is that we can't move forward here until node20 exists in all regions, which hasn't happened yet. I'm going to park this PR in draft mode, and when the time comes, revive it and get it in.

@kaizencc kaizencc marked this pull request as draft November 28, 2023 18:52
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib: NODEJS_LATEST still points to nodejs18.x
3 participants