Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ec2): fix typo in launch template #28758

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

furkanakkurt
Copy link
Contributor

While working on a project in which we create a launch template using the aws-ec2 module, I encountered a typo in the docstring, in which the word "SSH" had been typed as "SSK". This pull request aims to replace the word "SSK" with "SSH".


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 18, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 18, 2024 18:05
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@furkanakkurt furkanakkurt changed the title docs(aws-ec2): Fix typo in launch-template.ts docs(ec2): Fix typo in launch-template.ts Jan 18, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 18, 2024 18:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 18, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 19, 2024
@go-to-k
Copy link
Contributor

go-to-k commented Jan 19, 2024

The title of the PR might be docs(ec2): fix typo in launch template would be good.

@furkanakkurt furkanakkurt changed the title docs(ec2): Fix typo in launch-template.ts docs(ec2): fix typo in launch template Jan 19, 2024
@furkanakkurt
Copy link
Contributor Author

The title of the PR might be docs(ec2): fix typo in launch template would be good.

Updated the title

@furkanakkurt furkanakkurt requested a review from go-to-k January 19, 2024 10:39
Copy link
Contributor

mergify bot commented Jan 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 19, 2024
Copy link
Contributor

mergify bot commented Jan 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7e55ab3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b26e766 into aws:main Jan 19, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jan 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants