fix(apigatewayv2): WebSocketAwsIntegration ignores requestParameters #28905
Conversation
github-actions
bot
added
beginning-contributor
|
|
||
| /* | ||
| * Stack verification steps: | ||
| * 1. Verify manually that the integration has type "MOCK" |
There was a problem hiding this comment.
nit, this should say has type "AWS"
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
| credentialsRole: webSocketApiRole, | ||
| templateSelectionExpression: '\\$default', | ||
| requestTemplates: { | ||
| /*eslint quotes: ["error", "single", { "avoidEscape": true }]*/ |
There was a problem hiding this comment.
For my understanding, what is this comment for?
There was a problem hiding this comment.
Hi Gavin, it just allows you to avoid escapes when using single and double quotes for literals. You can certainly escape the single quotes if desired and remove the comments. https://eslint.org/docs/latest/rules/quotes
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
1 similar comment
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
#28718 missed adding requestParameters to the WebSocketAwsIntegration.