-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cdk synth is unable to find docker binary for bundling assets when using Macos #30593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
Closes #30570 .
Reason for this change
In some MacOs the path to Docker binary is not resolvable for CDK. Hence the need for pointing directly to docker binary which should be the same for all docker installations in Mac (if not should be resolved by existing measures)
Description of changes
Added a function getDockerCmdMac() and used in the existing getDockerCmd().
Description of how you validated changes
No unit tests are added due to missing of test environment (that being a macos with docker desktop installed)
Checklist
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license