-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(events-targets): KinesisStream
target not working when the stream is encrypted using a customer kms key
#30956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
KinesisStream
target not working when the stream is encrypted using a customer kms key
TBH I am not putting more effort into this, I looked at the tests and I have no idea how I am supposed to know the id-like characters needed to add a test checking if the policy also adds the required KMS permissions. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue #10996
Closes #10996
Reason for this change
Unless there is a specific reason that I am missing, I don't see why it was necessary to manipulate the policy directly rather than delegate to the
granWrite
method already provided by theIStream
interface, whose implementation would automatically also add the necessary KMS permissions to theRole
.Description of changes
Use
stream.grantWrite
rather than managing the IAM policy directly.Description of how you validated changes
Delegating to existing unit tests. I would also test these changes on our real code if a SNAPSHOT is released.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license