Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merge-queue): adding a new merge queue to tackle priority PR #33294

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Feb 4, 2025

Issue # (if applicable)

Closes NA.

Reason for this change

Adding a new merge queue to handle PRs that include a single commit like PR with custom resource changes that causes issue while releasing with other changes.

Description of changes

Update mergify.yml to add new merge queue.

Describe any new or updated permissions being added

No permissions related changes

Description of how you validated changes

yarn build
yarn test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 4, 2025 21:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 4, 2025
.mergify.yml Outdated
@@ -39,6 +39,25 @@ queue_rules:
{{ title }} (#{{ number }})
{{ body }}

- name: priority-merge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prever priority-squash

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (20d8427) to head (fc96473).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33294   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files         236      236           
  Lines       14235    14235           
  Branches     2487     2487           
=======================================
  Hits        11503    11503           
  Misses       2448     2448           
  Partials      284      284           
Flag Coverage Δ
suite.unit 80.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.14% <ø> (ø)

Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fc96473
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shikha372 shikha372 marked this pull request as ready for review February 4, 2025 23:14
@mergify mergify bot merged commit 3403da4 into aws:main Feb 4, 2025
24 checks passed
Copy link

github-actions bot commented Feb 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants