-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): update bit.ly link to be directly to github #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http://bit.ly link seems suspicious. At least make it `https`, or better yet link directly to the issue.
Pull Request Checklist
|
eladb
previously approved these changes
Aug 26, 2019
eladb
changed the title
Update bit.ly link to be directly to Github
chore(cli): update bit.ly link to be directly to Github
Aug 26, 2019
eladb
changed the title
chore(cli): update bit.ly link to be directly to Github
fix(cli): update bit.ly link to be directly to Github
Aug 26, 2019
eladb
changed the title
fix(cli): update bit.ly link to be directly to Github
fix(cli): update bit.ly link to be directly to github
Aug 26, 2019
Thank you for contributing! Your pull request is now being automatically merged. |
I agree, it's more transparent and clean to get this link updated. |
shivlaks
approved these changes
Aug 26, 2019
I think this is making the CLI Integration test fail. The change was made in the test but doesn't seem to be in CDK
|
Yep, well spotted. Fixing it now. |
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
* chore: fix CLI integration tests Fix breakage introduced by #3782, which changed the wrong string. Update other expectation to match change introduced in #3772. * Use substitutions in error message * Rewrite how CLI tests are being run * Extract environment setup from tests * Need to not ignore integ test Javascript files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http://bit.ly link seems suspicious. At least make it
https
, or better yet link directly to the issue.Update http://bit.ly/cdk-2EhF7Np => #1299
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license