Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): adding the ability to set the endpoint configuration for the OpenAPI 3.0 #9059

Closed
wants to merge 0 commits into from

Conversation

IsmaelMartinez
Copy link
Contributor

@IsmaelMartinez IsmaelMartinez commented Jul 14, 2020

feat(apigateway): adding the ability to set the endpoint configuration for the OpenAPI 3.0

With this change, it will be possible to modify this by providing the endpointConfiguration as shown here:

const api = new apigateway.SpecRestApi(this, 'ExampleRestApi', {
  apiDefinition: apigateway.ApiDefinition.fromInline(replacedSwagger),
  endpointConfiguration: {
    types: [apigateway.EndpointType.PRIVATE],
  },
});

Note: For private endpoints you will still need to provide the x-amazon-apigateway-policy in your openApi file.

Checklist for this PR:
🧪 Testing: adding integration testing for private API gateway.
📄 Docs: Add example in the README documentation about how to create a private API gateway with swagger
Fixes #9060

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@IsmaelMartinez IsmaelMartinez changed the title feat(apigateway) adding the ability to set the endpoint configuration for the SpecRestAPI feat(apigateway) adding the ability to set the endpoint configuration for the OpenAPI 3.0 Jul 14, 2020
@IsmaelMartinez IsmaelMartinez changed the title feat(apigateway) adding the ability to set the endpoint configuration for the OpenAPI 3.0 feat(apigateway): adding the ability to set the endpoint configuration for the OpenAPI 3.0 Jul 14, 2020
@pull pull bot closed this Jul 14, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4470e89
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@IsmaelMartinez
Copy link
Contributor Author

somehow that git pull bot has removed the commits so opened another PR

#9068

Automation sometimes have funny side effects. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[apigateway] support configuring endpoint types for SpecRestApi (Swagger/OpenApi)
3 participants