Skip to content

Commit

Permalink
Fix Impala configuration argument construction
Browse files Browse the repository at this point in the history
  • Loading branch information
Bhargava Kalathuru authored and kyleknap committed Feb 18, 2016
1 parent d8fba3b commit 8ca6ea8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion awscli/customizations/emr/applicationutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _build_impala_install_bootstrap_action(region, args=None):
constants.LATEST]
if args is not None:
args_list.append(constants.IMPALA_CONF)
args_list += args
args_list.append(','.join(args))
return emrutils.build_bootstrap_action(
name=constants.INSTALL_IMPALA_NAME,
path=emrutils.build_s3_link(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ def test_install_impala_with_all_fields(self):
result = copy.deepcopy(DEFAULT_RESULT)
ba = copy.deepcopy(INSTALL_IMPALA_BA)
ba['ScriptBootstrapAction']['Args'] += \
['--impala-conf', 'arg1', 'arg2']
['--impala-conf', 'arg1,arg2']
result['BootstrapActions'] = [ba]
self.assert_params_for_cmd(cmd, result)

Expand Down Expand Up @@ -952,7 +952,7 @@ def test_applications_all_types_from_json_file(self):
impala_ba = copy.deepcopy(INSTALL_IMPALA_BA)
impala_ba['ScriptBootstrapAction']['Args'] += \
['--impala-conf',
'IMPALA_BACKEND_PORT=22001', 'IMPALA_MEM_LIMIT=70%']
'IMPALA_BACKEND_PORT=22001,IMPALA_MEM_LIMIT=70%']
ba_list = [INSTALL_GANGLIA_BA, INSTALL_HBASE_BA,
impala_ba]
step_list = [INSTALL_HIVE_STEP, INSTALL_PIG_STEP, INSTALL_HBASE_STEP]
Expand Down

0 comments on commit 8ca6ea8

Please sign in to comment.