Fix shorthand parser regressions in 1.8.0 #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes the master regex more clear.
Fixes a reression in the new shorthand parser when a value has spaces, e.g. `foo=with space`. Only whitespace within the value is allowed. Trailing whitespace is still trimmed.
Regression with the new shorthand parser.
|
Change looks fine. Is there anything else that we need to take account for other than dashes like other symbol or unicode keys? Otherwise, 🚢 |
|
The key would correspond to valid names (not values) for AWS APIs. The only thing that I can think of that might affect this would be map names. I'll do some additional research on this. |
|
Actually, DynamoDB's |
|
Ok cool. Should be good to merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471 (unquoted values with spaces should be allowed).
Fixes #1470 (dash in key name should be allowed).
Added unit tests for these so we don't regress in the future.
cc @kyleknap @mtdowling @rayluo