-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description param to security group commands #4434
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 94.5% 94.53% +0.03%
===========================================
Files 188 188
Lines 14168 14174 +6
===========================================
+ Hits 13390 13400 +10
+ Misses 778 774 -4
Continue to review full report at Codecov.
|
5 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 94.5% 94.53% +0.03%
===========================================
Files 188 188
Lines 14168 14174 +6
===========================================
+ Hits 13390 13400 +10
+ Misses 778 774 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 94.5% 94.53% +0.03%
===========================================
Files 188 188
Lines 14168 14174 +6
===========================================
+ Hits 13390 13400 +10
+ Misses 778 774 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 94.5% 94.53% +0.03%
===========================================
Files 188 188
Lines 14168 14174 +6
===========================================
+ Hits 13390 13400 +10
+ Misses 778 774 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 94.5% 94.53% +0.03%
===========================================
Files 188 188
Lines 14168 14174 +6
===========================================
+ Hits 13390 13400 +10
+ Misses 778 774 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4434 +/- ##
===========================================
+ Coverage 94.5% 94.53% +0.03%
===========================================
Files 188 188
Lines 14168 14174 +6
===========================================
+ Hits 13390 13400 +10
+ Misses 778 774 -4
Continue to review full report at Codecov.
|
Hi @rbaker11, thanks for the PR. Apologies for the delay in getting back to you. Our team just put out a contribution guide detailing improvements to the contribution process. I have created issue #6981 for this PR. We will wait for the issue to receive 10 upvotes before moving this PR into the ready-for-review stage on our project board. The rationale for this can be found in the rationale section of the contribution guide.” Until then, I'm going to set this PR as a draft. |
Checking in as there has not been any recent activity here or on the corresponding issue (#6981). I think some further discussion is required regarding the use cases for the parameter, and why using |
Issue #, if available:
#6981
Description of changes:
This adds the ability to add a description when creating security group rules via a dedicated option (--description) instead of only via the --ip-permissions option.
I also added a unit test for the new functionality. Total code coverage for this file (awscli/customizations/ec2/secgroupsimplify.py) has improved from 89% to 92%.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.