Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Emit handlers before endpoint resolution #8687

Merged
merged 1 commit into from
May 23, 2024

Conversation

kdaily
Copy link
Member

@kdaily kdaily commented May 23, 2024

Issue #, if available:

This ports the following botocore pull request:

boto/botocore#2920

Description of changes:

Emit provide-client-params.* and before-parameter-build.* before endpoint resolution.

One update to the endpoint name in the test_signers.py unit test was applied to use the region name (us-east-1) in the s3 endpoint, consistent with existing CLI v2 tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily kdaily requested a review from kyleknap May 23, 2024 14:55
@kdaily kdaily marked this pull request as draft May 23, 2024 14:56
Emit `provide-client-params.*` and
`before-parameter-build.*` before endpoint
resolution.

This ports the following botocore pull request:

boto/botocore#2920

One update to the endpoint name in the
test_signers.py unit test was applied to use the
region name in the s3 endpoint, consistent with
existing CLI v2 tests.
@kdaily kdaily force-pushed the event-ordering-params-endpoints-v2 branch from 5909576 to d1c0301 Compare May 23, 2024 21:40
@kdaily kdaily marked this pull request as ready for review May 23, 2024 21:40
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@kdaily kdaily merged commit 96feaf7 into aws:v2 May 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants