-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use randomized bucket names for S3 integration tests. #9052
Conversation
69ce3e3
to
f422e97
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9052 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 210 210
Lines 16952 16955 +3
==========================================
Hits 14 14
- Misses 16938 16941 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming tests pass.
@@ -32,6 +32,7 @@ | |||
import tempfile | |||
import time | |||
import unittest | |||
import uuid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be used.
* release-1.35.21: Bumping version to 1.35.21 Update changelog based on model updates Add gh-pages branch to dependabot Use randomized bucket names for S3 integration tests. (#9052)
This change updates existing S3 integration tests to more away from static names and instead use randomized bucket names consistent with other tests.