Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use randomized bucket names for S3 integration tests. #9052

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

jonathan343
Copy link
Contributor

This change updates existing S3 integration tests to more away from static names and instead use randomized bucket names consistent with other tests.

@jonathan343 jonathan343 force-pushed the randomize-bucket-names branch from 69ce3e3 to f422e97 Compare November 4, 2024 19:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.08%. Comparing base (52985a2) to head (c6d90ac).
Report is 56 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/testutils.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #9052      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16952   16955       +3     
==========================================
  Hits            14      14              
- Misses       16938   16941       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming tests pass.

@jonathan343 jonathan343 merged commit bb6f89f into aws:develop Nov 4, 2024
30 checks passed
@@ -32,6 +32,7 @@
import tempfile
import time
import unittest
import uuid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used.

aws-sdk-python-automation added a commit that referenced this pull request Nov 6, 2024
* release-1.35.21:
  Bumping version to 1.35.21
  Update changelog based on model updates
  Add gh-pages branch to dependabot
  Use randomized bucket names for S3 integration tests. (#9052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants