Add CLI examples for CloudWatch NetworkFlowMonitor #9127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elysahall
added
documentation
elysahall
suggested changes
Jan 8, 2025
There was a problem hiding this comment.
Hi @chaitanyagummadi,
It looks like most of your examples are missing "for more information" links. Other than that there was only one grammar fix. After you finish the updates, commit and push your changes and we should be good to send for maintainer review.
...li/examples/networkflowmonitor/get-query-results-workload-insights-top-contributors-data.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/get-query-results-workload-insights-top-contributors.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/get-query-status-monitor-top-contributors.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/get-query-status-workload-insights-top-contributors-data.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/stop-query-monitor-top-contributors.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/stop-query-workload-insights-top-contributors-data.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/stop-query-workload-insights-top-contributors.rst
Outdated
Show resolved
Hide resolved
chaitanyagummadi
force-pushed
the
networkflowmonitor-cli
branch
from
c6c0153 to
19801bf
Compare
elysahall
approved these changes
Jan 22, 2025
elysahall
added
pr:needs-review
aemous
requested changes
Jan 23, 2025
...li/examples/networkflowmonitor/get-query-results-workload-insights-top-contributors-data.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/get-query-results-workload-insights-top-contributors.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/start-query-monitor-top-contributors.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/start-query-workload-insights-top-contributors-data.rst
Outdated
Show resolved
Hide resolved
awscli/examples/networkflowmonitor/start-query-workload-insights-top-contributors.rst
Outdated
Show resolved
Hide resolved
chaitanyagummadi
force-pushed
the
networkflowmonitor-cli
branch
from
45db25d to
a382fe3
Compare
|
@aemous I made a new commit fixing all the 7 files. Awaiting your review. Thanks! |
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9127 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 210 210
Lines 16978 16984 +6
==========================================
Hits 14 14
- Misses 16964 16970 +6 ☔ View full report in Codecov by Sentry. |
aws-sdk-python-automation
added a commit
that referenced
this pull request
Feb 3, 2025
* release-1.37.12: Bumping version to 1.37.12 Update changelog based on model updates Bump aws-actions/closed-issue-message from 1 to 2 Add CLI examples for CloudWatch NetworkFlowMonitor (#9127)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add CLI examples for Amazon CloudWatch NetWork Flow Monitor service:
https://docs.aws.amazon.com/cli/latest/reference/networkflowmonitor/#cli-aws-networkflowmonitor
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.