ci: create release builds that validate on multiple JDKs #148
Conversation
codebuild/release/release-prod.yml
Outdated
| @@ -0,0 +1,87 @@ | |||
| version: 0.2 | |||
| # 'release-prod' is an AWS::CodeBuild::Project that Releases from CodeArtifact to Sonatype and then validates the release with 'validate-prod' | |||
There was a problem hiding this comment.
Is this actually grabbing the jar in CodeArtifact and releasing that through Sonatype? It doesn't look like release-prod depends on any codeartifact token.
There was a problem hiding this comment.
I think you are correct. It does not... Which raises the question if it should. I guess not, since previous MCMs do not. Will correct.
| mvn verify \ | ||
| -Pcodeartifact \ | ||
| -Dcheckstyle.skip \ | ||
| -Desdk.version=$VERSION \ |
There was a problem hiding this comment.
This (sorry, should just be pointing to L26) shouldn't be needed, as we are verifying the examples pom in this same repo, which should already be updated with the version we want to test under.
Maybe this means that in the release codebuild that we should check the examples depends on the expected VERSION? Alternatively we could keep this in and update the examples pom to allow taking in a version like this (see what we do for busy-engineers-guide [1])
| pre_build: | ||
| commands: | ||
| - git checkout $COMMIT_ID | ||
| - FOUND_VERSION=$(grep version pom.xml | head -n 2 | sed -n 's/[ \t]*<version>\(.*\)<\/version>/\1/p') |
There was a problem hiding this comment.
So the DDBEC is structured a bit weirdly in that the version we want to actually check is at sdk1/pom.xml
There is a top level pom (it's intention was to de-dupe configuration between sdk1 and sdk2 poms when that was under development. The in progress sdk2 work was ripped out, but the pom structure stayed.), but it never gets packaged itself as a jar and released.
codebuild/release/release-prod.yml
Outdated
| pre_build: | ||
| commands: | ||
| - git checkout $COMMIT_ID | ||
| - FOUND_VERSION=$(grep version pom.xml | head -n 2 | sed -n 's/[ \t]*<version>\(.*\)<\/version>/\1/p') |
There was a problem hiding this comment.
Same here we need to check sdk1/pom.xml
codebuild/release/release-prod.yml
Outdated
| - | | ||
| mvn deploy \ | ||
| -Ppublishing \ | ||
| -Pfast-tests-only \ |
There was a problem hiding this comment.
This can be removed. This is a profile that exists in the ESDK that only runs unit tests. DDBEC doesn't have the equivalent profile, so it will just run through all it's unit/integration tests.
texastony
force-pushed
the
improve_ci
branch
3 times, most recently
from
615298c to
a0ae62c
Compare
|
Fudge... I was really hoping that by Forcing the branch back to the valid commit that had been approved, a0ae62c, GitHub would automatically re-apply @farleyb-amazon and @lavaleri approval. I am really surprised it did not... |
Issue #, if available: N/A
Description of changes: Test Release and Prod Release will validate a release on 4 different Java SDKs
I highly recommend a Squash and Merge approach.
Final commit message should be:
ci: test against multiple JDKsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: