fix : NPE if reading record without a signature fields #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What to do in order to get pass the checks. |
lavaleri
suggested changes
Aug 9, 2021
.../java/com/amazonaws/services/dynamodbv2/mapper/integration/MissingSignatureFieldsITCase.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptor.java
Outdated
Show resolved
Hide resolved
...st/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptorTest.java
Outdated
Show resolved
Hide resolved
.../java/com/amazonaws/services/dynamodbv2/mapper/integration/MissingSignatureFieldsITCase.java
Outdated
Show resolved
Hide resolved
.../java/com/amazonaws/services/dynamodbv2/mapper/integration/MissingSignatureFieldsITCase.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptor.java
Outdated
Show resolved
Hide resolved
added 3 commits
August 11, 2021 12:07
lavaleri
suggested changes
Aug 12, 2021
...c/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptor.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptor.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptor.java
Outdated
Show resolved
Hide resolved
...st/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptorTest.java
Outdated
Show resolved
Hide resolved
...st/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptorTest.java
Outdated
Show resolved
Hide resolved
...st/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptorTest.java
Outdated
Show resolved
Hide resolved
...st/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptorTest.java
Outdated
Show resolved
Hide resolved
.../java/com/amazonaws/services/dynamodbv2/mapper/integration/MissingSignatureFieldsITCase.java
Outdated
Show resolved
Hide resolved
.../java/com/amazonaws/services/dynamodbv2/mapper/integration/MissingSignatureFieldsITCase.java
Outdated
Show resolved
Hide resolved
.../java/com/amazonaws/services/dynamodbv2/mapper/integration/MissingSignatureFieldsITCase.java
Outdated
Show resolved
Hide resolved
|
@lavaleri please check my reply on the comments.. |
lavaleri
suggested changes
Aug 18, 2021
...c/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/DynamoDBEncryptor.java
Outdated
Show resolved
Hide resolved
farleyb-amazon
approved these changes
Aug 19, 2021
lavaleri
approved these changes
Aug 20, 2021
|
LGTM. Thank you, @bhuvangu, for your contribution! :) |
|
@lavaleri when is the next release schduled.. didnt find any release cycle in documentation |
|
Hi @bhuvangu, this change was released yesterday in our 2.0.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#123
Description of changes:
Read record without an amzn-ddb-map-desc
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.