Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: backport codebuild release from 2.x #229

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony texastony requested a review from a team as a code owner January 6, 2022 21:47
batch:
fast-fail: false
build-graph:
- identifier: release_to_prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step should have the buildspec file path, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so. This is referring to itself as the first step in the build batch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated this PR by verbatim copying the codebuild directory from 2.x into 1.x. Since we have successfully deployed 2.x with these buildspecs, I am inclined to trust that they are correct. I will double check with the other repos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@texastony
Copy link
Contributor Author

A test run of java-ddb-ec-test-release against this PR was successful.

@texastony texastony merged commit 4b19168 into aws:master-1.x Jan 6, 2022
@texastony texastony deleted the feat_release_automation branch January 6, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants