Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an ElasticBeanstalk deployment issue for Linux platform where Procfile was sometimes being generated with incorrect entrypoint when multiple runtimeconfig.json files were present. #363

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ashishdhingra
Copy link
Contributor

@ashishdhingra ashishdhingra commented Feb 19, 2025

Issue #, if available: #285

Description of changes:
Fixed an ElasticBeanstalk deployment issue for Linux platform where Procfile was sometimes being generated with incorrect entrypoint when multiple runtimeconfig.json files were present.

The existing logic to determine the project file .csproj uses Utilitites.FindProjectFileInDirectory(). It has explicit check here to ensure that we get only one project file; else it returns null. So in case there are multiple project files, it would probably throw NullReferenceException in subsequent logic. We are using this assumption that we only have one project file for deployment at root of working directory, to get the assembly name (via msbuild).

Also note that we also invoke BaseCommand.EnsureInProjectDirectory(). This throws generic exception $"No .NET project found in directory {projectLocation} to build." in case where more than one project file if found in working directory, which might be incorrect or misleading.

NOTE:
Refer Using a Procfile to configure your .NET Core on Linux Elastic Beanstalk environment where it shows below example to configure 2 web applications.

web: dotnet ./dotnet-core-app1/dotnetcoreapp1.dll
web2: dotnet ./dotnet-core-app2/dotnetcoreapp2.dll

The PR supports one web application as of now to conform to existing logic.
CC @normj


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…rocfile was sometimes being generated with incorrect entrypoint when multiple runtimeconfig.json files were present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant