API incorrectly filters delta messages

[johnhopwood]

shadowJsonVersionNum can be incremented by non .../delta topic messages resulting in a risk of missing delta messages. The issue is recognized in the comments here:

https://github.com/aws/aws-iot-device-sdk-embedded-C/blob/master/include/aws_iot_shadow_interface.h#L260

However, messages received on .../update/accepted are incorrectly being allowed to increment shadowJsonVersionNum by the code here:

https://github.com/aws/aws-iot-device-sdk-embedded-C/blob/master/src/aws_iot_shadow_records.c#L173

A quick fix is to remove the test (strstr(pTopicName, "update/accepted") != NULL although a more robust approach could be to track version number per subscribed topic.

[Borschtsch]

Same finding is posted here.

[Borschtsch]

I also found this issue logged for previous release, but the issue is still there.

[chaurah]

Hi @johnhopwood,
Thank you for letting us know you're facing this issue. We are already working to address this in the next release. I realize it has been pending for a while now, it will definitely be addressed in the next version of the SDK. Apologies for any inconvienience this is causing. Thank you for using AWS IoT.

Rahul