Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compilation warnings #78

Closed
wants to merge 2 commits into from
Closed

Fixed compilation warnings #78

wants to merge 2 commits into from

Conversation

nikitanerkar
Copy link

Fixed gcc compilation warnings

@chaurah
Copy link
Contributor

chaurah commented Feb 23, 2017

Hi Nikita,
Thank you for this pull request. I have added it to our internal tracker as well to make sure it gets merged as applicable to the next release of the SDK. Please do let me know if you have any further suggestions.

Rahul

@nikitanerkar
Copy link
Author

nikitanerkar commented Mar 2, 2017 •
edited
Loading

@chaurah Please view following change as well
2a21795

@nikitanerkar nikitanerkar reopened this Mar 2, 2017
@chaurah
Copy link
Contributor

chaurah commented Mar 2, 2017

Thank you for this update Nikita. I think an additional option, where the timer increases to the maximum value and then keeps retrying with the max value would also be useful. I will add this to our internal tracker.
As always, please let me know if you have any further suggestions.

Rahul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitanerkar @chaurah