change append to extend to fix bytestream error #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
approved these changes
Mar 3, 2022
j123b567
reviewed
Apr 4, 2022
| while True: # Python does not have do-while | ||
| try: | ||
| response.append(self._convert_to_int_py3(ssl_sock.read(1))) | ||
| ssl_sock_tmp = self._convert_to_int_py3(ssl_sock.read(1)) | ||
| if ssl_sock_tmp is list: |
There was a problem hiding this comment.
This condition is always False!
ssl_sock_tmp = []
ssl_sock_tmp is list # False
type(ssl_sock_tmp) is list # True
isinstance(ssl_sock_tmp, list) # True
There was a problem hiding this comment.
Thanks @j123b567 - you are right, I just tested using a simple program and it always returns false even if it is a list. I'll make a PR to adjust this so it correctly evaluates the type. Thank you for letting us know!
There was a problem hiding this comment.
PR made: #307
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#295
Description of changes:
change append to extend to fix bytestream error
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.