-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python ARM build issue #321
Conversation
@eldritchideen This looks good to me. I am clarifying with the team on the CI for this repo. It doesn't look like we actually run ARM tests at all or I am missing where that happens at. If we aren't, then we don't have anything actually running the tests you created (or verifying arm at all). So want to make sure/understand how we have been doing this. |
So we don't run arm tests :( but we need to do that. Appveyor doesn't support arm. I think we may need to move to codebuild (at least for arm) but that is out of scope for this. I am ok with this change knowing the arm tests are not running :( @eldritchideen Did you validate this on arm locally some how? |
Yes, tested on an AL2 t4g instance. |
@eldritchideen Thank you for the contribution! |
Issue #, if available:
#302
Description of changes:
This PR fixes the issue where SAM fails to package up a dependency on ARM where
pip
needs to build the wheel from source that contains a C extension. The wheel when build is named forwrapt-1.13.3-cp39-cp39-linux_aarch64.whl
and this doesn't match the current list of compatible platforms for ARM. This has previously been reported with thewrapt
library used by the XRay SDK.@heitorlessa @jfuss
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.