Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python ARM build issue #321

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

eldritchideen
Copy link
Contributor

Issue #, if available:
#302

Description of changes:
This PR fixes the issue where SAM fails to package up a dependency on ARM where pip needs to build the wheel from source that contains a C extension. The wheel when build is named for wrapt-1.13.3-cp39-cp39-linux_aarch64.whl and this doesn't match the current list of compatible platforms for ARM. This has previously been reported with the wrapt library used by the XRay SDK.

@heitorlessa @jfuss

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss
Copy link
Contributor

jfuss commented Feb 1, 2022

@eldritchideen This looks good to me. I am clarifying with the team on the CI for this repo. It doesn't look like we actually run ARM tests at all or I am missing where that happens at. If we aren't, then we don't have anything actually running the tests you created (or verifying arm at all). So want to make sure/understand how we have been doing this.

@jfuss
Copy link
Contributor

jfuss commented Mar 1, 2022

So we don't run arm tests :( but we need to do that. Appveyor doesn't support arm. I think we may need to move to codebuild (at least for arm) but that is out of scope for this. I am ok with this change knowing the arm tests are not running :(

@eldritchideen Did you validate this on arm locally some how?

@eldritchideen
Copy link
Contributor Author

@eldritchideen Did you validate this on arm locally some how?

Yes, tested on an AL2 t4g instance.

@torresxb1 torresxb1 merged commit 908ad5f into aws:develop Mar 8, 2022
@torresxb1
Copy link
Contributor

@eldritchideen Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants