Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Android support #471

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jul 29, 2024

Issues:

Addresses: V1450305954

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title Update aws-lc-fips-sys to v0.12.11 Improve Android support Jul 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (c358484) to head (1d53769).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   95.80%   92.83%   -2.97%     
==========================================
  Files          61       62       +1     
  Lines        8143     8626     +483     
  Branches        0     8626    +8626     
==========================================
+ Hits         7801     8008     +207     
- Misses        342      362      +20     
- Partials        0      256     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the improve-android-support branch 6 times, most recently from 857930f to 973bf81 Compare July 30, 2024 16:15
@justsmth justsmth force-pushed the improve-android-support branch from 973bf81 to b5eb754 Compare July 30, 2024 16:34
@justsmth justsmth marked this pull request as ready for review July 30, 2024 16:37
@justsmth justsmth requested a review from a team as a code owner July 30, 2024 16:37
skmcgrail
skmcgrail previously approved these changes Jul 30, 2024
aws-lc-sys/builder/cmake_builder.rs Outdated Show resolved Hide resolved
samuel40791765
samuel40791765 previously approved these changes Jul 30, 2024
@justsmth justsmth dismissed stale reviews from samuel40791765 and skmcgrail via 1d53769 July 30, 2024 17:09
@justsmth justsmth merged commit 2e1d26c into aws:main Jul 30, 2024
190 of 195 checks passed
@justsmth justsmth deleted the improve-android-support branch July 30, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants