Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Ensure ConstPointers don't outlive parent #693

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 10, 2025

See latest commits:

Description of changes:

TODO

Call-outs:

TODO

Testing:

TODO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 85.73248% with 112 lines in your changes missing coverage. Please review.

Project coverage is 93.03%. Comparing base (c358484) to head (3177703).
Report is 167 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/pqdsa/key_pair.rs 86.22% 6 Missing and 21 partials ⚠️
aws-lc-rs/src/evp_pkey.rs 91.74% 10 Missing and 8 partials ⚠️
aws-lc-rs/src/ed25519.rs 59.52% 4 Missing and 13 partials ⚠️
aws-lc-rs/src/ec.rs 66.66% 4 Missing and 5 partials ⚠️
aws-lc-rs/src/ec/encoding.rs 65.21% 0 Missing and 8 partials ⚠️
aws-lc-rs/src/rsa/key.rs 75.86% 2 Missing and 5 partials ⚠️
aws-lc-rs/src/agreement.rs 55.55% 0 Missing and 4 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 66.66% 0 Missing and 3 partials ⚠️
aws-lc-rs/src/pqdsa/signature.rs 92.68% 0 Missing and 3 partials ⚠️
aws-lc-rs/src/rsa/encryption.rs 66.66% 1 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   95.80%   93.03%   -2.77%     
==========================================
  Files          61       71      +10     
  Lines        8143     9839    +1696     
  Branches        0     9839    +9839     
==========================================
+ Hits         7801     9154    +1353     
- Misses        342      395      +53     
- Partials        0      290     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants