Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<&PublicKey> for PublicKeyComponents #698

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Feb 18, 2025

Issues:

Addresses #697

Description of changes:

Add conversion from &PublicKey to PublicKeyComponents<&[u8]>. Seems pretty straightforward?

(I looked at the minor issue as well, but I'm not sure how to compute the correct public_modulus_len() from the decomposed modulus.)

Testing:

No tests yet -- let me know if/where I should add some test coverage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@djc djc requested a review from a team as a code owner February 18, 2025 10:49
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (c358484) to head (6408d4d).
Report is 169 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/rsa/key.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   95.80%   92.87%   -2.93%     
==========================================
  Files          61       70       +9     
  Lines        8143     9517    +1374     
  Branches        0     9517    +9517     
==========================================
+ Hits         7801     8839    +1038     
- Misses        342      412      +70     
- Partials        0      266     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit cb469dc into aws:main Feb 18, 2025
252 of 264 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants