[IGNORE, DRAFT] Test upstream #1739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarch64's SVE2 extension adds more syntax forms for registers, and a new "tweak" pattern that means "multiply offset by the hardware's vector length". This change tweaks delocate so that it can pass these forms. See https://developer.arm.com/documentation/102340/0100/SVE2-architecture-fundamentals Change-Id: I9a736dcf0b57d36d5e08a53e073da7fe3c62dea2 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65349 Commit-Queue: David Benjamin <[email protected]> Reviewed-by: David Benjamin <[email protected]> Auto-Submit: Adam Langley <[email protected]> (cherry picked from commit 672efb1f8ee029762e29ff16811b68a071a0528e) AWS-LC: Merged in delocator instructions for SVE2 Generated new delecote.peg.go file
The CROS_EC and CROS_ZEPHYR platforms currently have threads disabled, so we should not attempt to search for (or link) a threads library. BUG=b/273639386 Change-Id: I094a989680160f9ecefbdb4cb3e94c4825a651e3 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65568 Reviewed-by: David Benjamin <[email protected]> Reviewed-by: Bob Beck <[email protected]> Commit-Queue: Bob Beck <[email protected]> (cherry picked from commit becb3ffccdecff83047285ebea20e5b85b2d65b1)
The trust and purpose is all a bit tied up together, as is the meaning of the certificates in an X509_STORE at all. (It's hard to discuss whether a "trusted certificate" is actually a trust anchor without a description of trust settings to reference.) Cut the Gordian Knot by documenting all that first. Later CLs will move other symbols into the sections established here. Also as the behavior is a little complex, add some tests to cover some of this machinery. Bug: 426 Change-Id: Idde8bc4e588de92ebabf6ecf640b62a2a6803688 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65207 Commit-Queue: David Benjamin <[email protected]> Reviewed-by: Bob Beck <[email protected]> (cherry picked from commit 352740cef428f0f1eccdfff8dca9aaf1f85e31e4) AWS-LC: Moved functions around in x509.h Added two new tests to x509_test.cc
X509_STORE_CTX_purpose_inherit's behavior is even more bizarre than X509_STORE_CTX_set_purpose and X509_STORE_CTX_set_trust. Remove it and reimplement X509_STORE_CTX_set_purpose and X509_STORE_CTX_set_trust's behaviors directly. Change-Id: Icc6a4a84ee8fa38e2fe70a4cfa06e74dee186d29 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65208 Reviewed-by: Bob Beck <[email protected]> Commit-Queue: David Benjamin <[email protected]> (cherry picked from commit 3d9e5a355b1ce8518aefce2df00dfab3fe63c379)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
+ Coverage 78.29% 78.44% +0.14%
==========================================
Files 580 580
Lines 96552 96735 +183
Branches 13838 13870 +32
==========================================
+ Hits 75598 75886 +288
+ Misses 20341 20233 -108
- Partials 613 616 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.