Specifying CPU threads in cmake_build.sh to fix CI failures #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
=======================================
Coverage 78.30% 78.31%
=======================================
Files 580 580
Lines 96624 96623 -1
Branches 13853 13851 -2
=======================================
+ Hits 75661 75666 +5
+ Misses 20347 20344 -3
+ Partials 616 613 -3 ☔ View full report in Codecov by Sentry. |
smittals2
changed the title
andrewhop
approved these changes
Aug 3, 2024
samuel40791765
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A previous PR (https://github.com/aws/aws-lc/pull/1735/files) broke the CI but was merged in since the failed checks were not required. This PR fixes these failures by explicitly setting the number of threads to parallelize the make command (as opposed to using -j to spin up as many processes as possible).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.