-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PKCS7_verify, update PKCS7_sign #1993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
==========================================
+ Coverage 78.68% 78.76% +0.07%
==========================================
Files 598 598
Lines 103323 103620 +297
Branches 14686 14738 +52
==========================================
+ Hits 81301 81617 +316
+ Misses 21372 21351 -21
- Partials 650 652 +2 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
force-pushed
the
pkcs7-ruby
branch
2 times, most recently
from
November 18, 2024 18:17
ebb86d2
to
a94835a
Compare
WillChilds-Klein
changed the title
[DO NOT MERGE] Ruby/PKCS7 integration CI checks
[DRAFT] Implement PKCS7_verify, update PKCS7_sign
Nov 18, 2024
WillChilds-Klein
force-pushed
the
pkcs7-ruby
branch
3 times, most recently
from
November 19, 2024 13:15
59a15a7
to
b18f29c
Compare
WillChilds-Klein
force-pushed
the
pkcs7-ruby
branch
8 times, most recently
from
November 29, 2024 18:17
e94fa2a
to
576945c
Compare
WillChilds-Klein
changed the title
[DRAFT] Implement PKCS7_verify, update PKCS7_sign
Implement PKCS7_verify, update PKCS7_sign
Nov 29, 2024
WillChilds-Klein
force-pushed
the
pkcs7-ruby
branch
from
December 2, 2024 16:45
576945c
to
488ea0a
Compare
WillChilds-Klein
force-pushed
the
pkcs7-ruby
branch
from
December 2, 2024 16:47
488ea0a
to
94f9310
Compare
justinwsmith
reviewed
Dec 4, 2024
justinwsmith
reviewed
Dec 4, 2024
justsmth
reviewed
Dec 6, 2024
justsmth
reviewed
Dec 6, 2024
justsmth
approved these changes
Dec 6, 2024
samuel40791765
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR implements
PKCS7_verify
for verifying signedData-type PKCS7 messages. It also adds another mode of operation toPKCS7_sign
for compatibility with Ruby. Flags for these functions are documented in header comments.We also remove most support for signedAndEnveloped-type PKCS7 messges, as they're not required by Ruby's tests beyond a few getters/setters. OpenSSL supports this type in
PKCS7_decrypt
but notPKCS7_verify
,PKCS7_sign
, norPKCS7_encrypt
, so it's unclear what (if any) role signedAndEnveloped types have with respect to these functions. If we wish to revisit support for this type in the future, I have a branch here implementing encrypt/decrypt/sign/verify support and a test.Lastly, we externalize some of the previously internal PKCS7 ASN.1/struct definitions as ruby's source accesses some of their members directly.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.