-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x509-limbo patch and reporting tool #2049
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 598 598
Lines 103650 103650
Branches 14718 14720 +2
=======================================
Hits 81633 81633
+ Misses 21366 21365 -1
- Partials 651 652 +1 ☔ View full report in Codecov by Sentry. |
22c6e8f
to
63b0742
Compare
63b0742
to
85585f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had an issue with the script failing when the dev workspace already has a "build" directory. Otherwise, I just have some nit-picks.
I also noticed this error message.
I suspect that the Makefile's
|
@@ -0,0 +1,15 @@ | |||
.PHONY: all build test fmt vet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it common to use makefile with go code? Or is this a x509-limbo specific thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a data source to point towards, but just from experience it tends to be the go to tool to automate multiple actions for invoking, testing, vetting, etc a Go application. The Go compiler itself does a lot of the leg work when you invoke the build
sub-command to slurp up the appropriate files etc. Since Make tends to be readily available it tends to be an obvious choice.
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Linux CodeBuild projectGitHub Actions CI. This is only temporary.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.