Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Move ML-DSA to FIPS module.
ML-DSA is still off by default in the FIPS module. We will be removing the enable_dilithium flag in #2096.
Description of changes:
The following files have been moved from the
crypto/dilithium/
directory:p_pqdsa_test.cc
moved toevp_extra/p_pqdsa_test.cc
pqcrystals_dilithium_ref_common/
moved tofipsmodule/ml_dsa/ml_dsa_ref/
ml_dsa.{h/c}
moved tofipsmodule/ml_dsa/
This is consistant with the
ML-KEM
implementation in the fipsmodule, that has akem
folder (analogous to thepqdsa
folder) andml_kem
folder (analogous toml_dsa
folder).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.