Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ML-DSA to FIPSMODULE #2095

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Jan 6, 2025

Issues:

Move ML-DSA to FIPS module.

ML-DSA is still off by default in the FIPS module. We will be removing the enable_dilithium flag in #2096.

Description of changes:

The following files have been moved from the crypto/dilithium/ directory:

  • Testing framework p_pqdsa_test.cc moved to evp_extra/p_pqdsa_test.cc
  • Reference implementation directory pqcrystals_dilithium_ref_common/ moved to fipsmodule/ml_dsa/ml_dsa_ref/
  • ml_dsa.{h/c} moved to fipsmodule/ml_dsa/

This is consistant with the ML-KEM implementation in the fipsmodule, that has a kem folder (analogous to the pqdsa folder) and ml_kem folder (analogous to ml_dsa folder).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@jakemas jakemas requested a review from a team as a code owner January 6, 2025 21:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (edeb62f) to head (5e54cda).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
+ Coverage   78.74%   78.76%   +0.01%     
==========================================
  Files         598      598              
  Lines      103656   103656              
  Branches    14720    14719       -1     
==========================================
+ Hits        81629    81645      +16     
+ Misses      21375    21359      -16     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sources.cmake Outdated Show resolved Hide resolved
generated-src/crypto_test_data.cc Outdated Show resolved Hide resolved
crypto/fipsmodule/ml_dsa/ml_dsa.c Outdated Show resolved Hide resolved
crypto/fipsmodule/ml_dsa/ml_dsa_ref/poly.c Show resolved Hide resolved
@WillChilds-Klein WillChilds-Klein enabled auto-merge (squash) January 7, 2025 22:26
@WillChilds-Klein WillChilds-Klein merged commit c826c21 into aws:main Jan 7, 2025
124 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants