Move the tuner's selecting debug print to INFO level #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a useful print to debug issues with algorithm selection at scale without having to rebuild the plugin. While the actual costs calculated are more developer-focused and can stay under TRACE, the final choice should be available to INFO when the TUNING debug subsystem is enabled. NCCL 2.20 moved their algo/proto selection print from a TRACE to INFO for this reason as well. Signed-off-by: Raghu Raja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful print to debug issues with algorithm selection at scale without having to rebuild the plugin. While the actual costs calculated are more developer-focused and can stay under TRACE, the final choice should be available to INFO when the TUNING debug subsystem is enabled.
NCCL 2.20 moved their algo/proto selection print from a TRACE to INFO for this reason as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.