Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #382 #384

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix for #382 #384

merged 3 commits into from
Apr 11, 2024

Conversation

rajachan
Copy link
Member

b1bc116 (HEAD -> fix-dist, rajachan/fix-dist) build: Add headers that were missing in the distribution
176555b ci: Add --enable-platform-aws to Github distcheck action
60e3f8f m4: Pass enable-aws-platform config to distcheck's config

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


Confirmed with a Github distcheck build in my repo's actions that the AWS platform config is now included.

@bwbarrett
Copy link
Contributor

Sigh; I really should have figured out how to strip out the unsafe configure arguments for the AM_DISTCHECK_CONFIGURE_FLAGS (for example, you can't pass prefix or libdir or any of those). Let's see if we can circle back to that.

@rajachan rajachan marked this pull request as ready for review April 11, 2024 17:41
@rajachan rajachan requested a review from a team as a code owner April 11, 2024 17:41
@rajachan rajachan added the BuildTriggerRequest CI build will be triggered when this label is set label Apr 11, 2024
@rajachan rajachan merged commit 3df302e into aws:master Apr 11, 2024
13 checks passed
@rajachan rajachan deleted the fix-dist branch April 11, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BuildTriggerRequest CI build will be triggered when this label is set
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants