rdma: (fix) memory leak: don't alloc recv_conn_resp_req on EAGAIN
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
force-pushed
the
fix-eagain-memory-leak
branch
from
8a2ac95 to
3dc0cd1
Compare
AmedeoSapio
previously approved these changes
Apr 13, 2024
Move call to `prepare_recv_conn_resp_req` before entry point of `COMM_SEND_CONN` stage. This resolves a potential memory leak where `prepare_recv_conn_resp_req` is called multiple times on EAGAIN. Also fixup a similar case in `accept`, although there was no memory allocation there so no leak. Signed-off-by: Eric Raut <[email protected]>
rauteric
force-pushed
the
fix-eagain-memory-leak
branch
from
3dc0cd1 to
7b119db
Compare
|
Fixed a similar case in |
AmedeoSapio
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move call to
prepare_recv_conn_resp_reqbefore entry point ofCOMM_SEND_CONNstage.This resolves a potential memory leak where
prepare_recv_conn_resp_reqis called multiple times on EAGAIN.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.