1.6.1 develop to master merge

[fnubalaj]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[chambm]

I don't know what prompted this change, but it was problematic for me. It took me a while to track this down as the reason my compute nodes weren't joining the scheduler. I had used the cfncluster.cfn.json directly to start a cluster via the AWS CFN web interface. I chose a more descriptive name that didn't start with "cfncluster-" so it didn't have the right permission for DescribeStacks.

[sean-smith]

You're specifically referencing this commit: 486a913

You can use a custom ec2_iam_role and give it broader DescribeStacks permissions. Unfortunately we want to scope the iam permissions down to just cfncluster stacks, so for your use case you'd need a custom role.
See https://cfncluster.readthedocs.io/en/latest/configuration.html#ec2-iam-role
And https://cfncluster.readthedocs.io/en/latest/iam.html

[chambm]

I need a custom IAM role for having a custom stack name? If that's the case, then somewhere there needs to be a check that if there is no custom IAM role, the stack name must match cfncluster-*. So I would have found out a lot sooner (and cheaper) that I needed to rename the stack. :)

[sean-smith]

I guess the fundamental issue here is we name all stacks cfncluster- in the cli, and we assume that stacks created by cfncluster follow that naming criteria.

We are not taking into account stacks created outside the cli.