Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate FSx Params #904

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

sean-smith
Copy link
Contributor

I've added two validations:

  1. import_path needs to be specified when using imported_file_chunk_size or export_path
  2. Only Supported OS is centos7

Signed-off-by: Sean Smith [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sean-smith sean-smith force-pushed the config-sanity-fsx branch 2 times, most recently from 9fb6eab to 513766a Compare March 1, 2019 20:47
cli/pcluster/cfnconfig.py Outdated Show resolved Hide resolved
cli/pcluster/cfnconfig.py Outdated Show resolved Hide resolved
cli/pcluster/cfnconfig.py Outdated Show resolved Hide resolved
cli/pcluster/config_sanity.py Outdated Show resolved Hide resolved
@sean-smith sean-smith force-pushed the config-sanity-fsx branch 2 times, most recently from 2f8d41f to 61383a6 Compare March 6, 2019 00:10
cli/pcluster/cfnconfig.py Outdated Show resolved Hide resolved
cli/pcluster/cfnconfig.py Outdated Show resolved Hide resolved
@sean-smith sean-smith force-pushed the config-sanity-fsx branch 2 times, most recently from b6beb1e to fced354 Compare March 6, 2019 16:51
* `import_path` needs to be specified when using `imported_file_chunk_size` or `export_path`
* Only Supported OS is `centos7`

Signed-off-by: Sean Smith <[email protected]>
Copy link
Contributor

@demartinofra demartinofra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sean-smith sean-smith merged commit b0aa371 into aws:develop Mar 6, 2019
@sean-smith sean-smith deleted the config-sanity-fsx branch October 29, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants