Deprecate provided, go1.x and java8 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
approved these changes
Mar 20, 2024
1 task
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Oct 17, 2024
### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change The `build-go` [image](https://gallery.ecr.aws/sam/build-go1.x) is [depracated](aws/aws-sam-build-images#139). ### Description of changes As recommended in [this announcement](https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-from-the-go1-x-runtime-to-the-custom-runtime-on-amazon-linux-2/), migrating the base image of `aws-lambda-go-alpha` integration test dockerfile base image to `al2023`. Additionally, an assertion was added to test the lambda function invocation. This is a custom lambda runtime, as previouse comment noted, the [aws-lambda-go](https://github.com/aws/aws-lambda-go) runtime package is not available. ### Description of how you validated changes - `yarn integ-runner --directory packages/@aws-cdk/aws-lambda-go-alpha` ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Deprecate build images for
provided,go1.xandjava8as these runtimes are deprecated on 3/12 - https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.htmlBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.