Skip to content

Commit

Permalink
fix: appveyor windows job - python version (#1776)
Browse files Browse the repository at this point in the history
* fix: appveyor windows job - python version

Why is this change necessary?

* With release v0.41.0 - MSIs have version 3.7.6 as their base version.
Appveyor testing needs to reflect that.

How does it address the issue?

* Appveyor test frameworks are now using python 3.7.6. The environment
variables are set according to: https://www.appveyor.com/docs/windows-images-software/

What side effects does this change have?

* None

* fix: change windows python versions across all appveyor projects

* fix: remove `PYTHON_VERSION` env variable in windows appveyor

- It does not look to be used.

* fix: remove python3.8 installation on windows python build appveyor
project

* Fix python path with python3.8 and 3.6

* check: does python3.8 exist on the windows appveyor image?

* fix: python3.8 path

url: appveyor/ci#3142

* fix: re-install python3.8 as before

Co-authored-by: Jacob Fuss <[email protected]>
  • Loading branch information
sriram-mv and jfuss authored Feb 6, 2020
1 parent 91c22c3 commit 1c83bb0
Show file tree
Hide file tree
Showing 8 changed files with 35 additions and 43 deletions.
9 changes: 4 additions & 5 deletions appveyor-windows-build-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand Down
9 changes: 4 additions & 5 deletions appveyor-windows-build-go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand Down
9 changes: 4 additions & 5 deletions appveyor-windows-build-java-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand Down
9 changes: 4 additions & 5 deletions appveyor-windows-build-java-ruby-inprocess.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ environment:
APPVEYOR_CI_OVERRIDE: 1
GRADLE_OPTS: -Dorg.gradle.daemon=false

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'

install:
Expand Down
9 changes: 4 additions & 5 deletions appveyor-windows-build-nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand Down
15 changes: 7 additions & 8 deletions appveyor-windows-build-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand All @@ -35,19 +34,19 @@ init:


install:

# Make sure the temp directory exists for Python to use.
# Install python3.8
- "choco install chocolatey-core.extension --version 1.3.3 --force -y"
- "choco install python3 --version 3.8.0"
- "C:\\Python38\\python.exe -m pip freeze"
- "refreshenv"

- ps: "mkdir -Force D:\\tmp"
- "SET PATH=%PYTHON_HOME%;%PATH%;C:\\Python37-x64;C:\\Python27-x64;C:\\Python38"
- "SET PATH=%PYTHON_HOME%;%PATH%;C:\\Python36-x64;C:\\Python27-x64;C:\\Python38"
- "echo %PYTHON_HOME%"
- "echo %PATH%"
- "python --version"
# Check if python3.8 exists on the image
- "C:\\Python38\\python.exe --version"

# Upgrade setuptools, wheel and virtualenv
- "python -m pip install --upgrade setuptools wheel virtualenv"
Expand Down
9 changes: 4 additions & 5 deletions appveyor-windows-build-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand Down
9 changes: 4 additions & 5 deletions appveyor-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@ environment:
TEMP: D:\tmp
TMP: D:\tmp

# MSI Installers only use Py3.6.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python36-x64"
PYTHON_SCRIPTS: "C:\\Python36-x64\\Scripts"
PYTHON_EXE: "C:\\Python36-x64\\python.exe"
PYTHON_VERSION: '3.6.8'
# MSI Installers only use Py3.7.6. It is sufficient to test with this version here.
PYTHON_HOME: "C:\\Python37-x64"
PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts"
PYTHON_EXE: "C:\\Python37-x64\\python.exe"
PYTHON_ARCH: '64'
HOME: 'C:\Users\appveyor'
HOMEDRIVE: 'C:'
Expand Down

0 comments on commit 1c83bb0

Please sign in to comment.