Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add integration tests for local invoke related to AWS credentials #2449

Merged

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Dec 4, 2020

Which issue(s) does this change fix?

Adding additional integration tests which will validate provided credentials are working as expected with local invoke command

Why is this change necessary?

For stopping any breaking change related to credential access.

Checklist

  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci merged commit c1b05ce into aws:develop Dec 11, 2020
moelasmar pushed a commit to moelasmar/aws-sam-cli that referenced this pull request Dec 11, 2020
…aws#2449)

* ci: add integration tests for local invoke which uses credentials

* ci: add nodejs, dotnet, golang projects. removed env vars for process

* chore: update build command verification

Co-authored-by: mgrandis <[email protected]>
bramkoot pushed a commit to bramkoot/aws-sam-cli that referenced this pull request Jan 15, 2021
…aws#2449)

* ci: add integration tests for local invoke which uses credentials

* ci: add nodejs, dotnet, golang projects. removed env vars for process

* chore: update build command verification

Co-authored-by: mgrandis <[email protected]>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Jan 19, 2021
…aws#2449)

* ci: add integration tests for local invoke which uses credentials

* ci: add nodejs, dotnet, golang projects. removed env vars for process

* chore: update build command verification

Co-authored-by: mgrandis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants