Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken integration tests due to new Go code binding in EB #3785

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Mar 30, 2022

Which issue(s) does this change fix?

EB Go binding was introduced in PR #3657. However, it affected existing interactive init flow test cases as go became the first runtime option and everything else shifted downward by 1. This PR fixes these broken test cases.

Why is this change necessary?

Fix tests

How does it address the issue?

Update the inputs

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau merged commit ebdae7f into aws:develop Mar 30, 2022
@hawflau hawflau deleted the fix-eb-init branch March 30, 2022 19:38
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants