ci: add gh action to generate and test pyinstaller zip file #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingchm
reviewed
Dec 15, 2022
qingchm
approved these changes
Dec 16, 2022
sriram-mv
reviewed
Dec 17, 2022
sriram-mv
approved these changes
Dec 20, 2022
| run: | | ||
| unzip .build/output/aws-sam-cli-linux-x86_64.zip -d sam-installation | ||
| ./sam-installation/install | ||
| sam-beta --version |
There was a problem hiding this comment.
Not blocking: can we kick off another suite of tests that is bare bones across the commands, such that each command is atleast invoked once? could be a follow up commit. Could be a first step towards artifact based testing.
There was a problem hiding this comment.
I do agree with this. But I would rather have that as a separate PR and include the tests that we want to run with the pyinstaller. So that we can incrementally improve our installer test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates a pyinstaller zip file for linux & mac and runs some basic tests. ZIP file will also added as artifact so that it can be downloaded and tested with each PR.
build-linux.shandbuild-mac.shbehaves differently ifCI_OVERRIDEenvironment variable is set to1:aws-sam-cli-betasam-beta(different than what we have as of now [samdev,sam-nigtly,sam])By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.