Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hooks data imports for pyinstaller #4491

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: hooks data imports for pyinstaller #4491

merged 1 commit into from
Dec 16, 2022

Conversation

sriram-mv
Copy link
Contributor

  • import cfnlint with data files, python files and package metadata directories.

Which issue(s) does this change fix?

  • Nightly builds for pyinstaller

Why is this change necessary?

  • Previous change did not include the hidden imports

How does it address the issue?

  • validate with --lint now works with the appropriate imports.

What side effects does this change have?

  • N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv
fix: hooks data imports for pyinstaller
8ba55ed 
- import `cfnlint` with data files, python files and package metadata
  directories.
@sriram-mv sriram-mv requested a review from a team as a code owner December 16, 2022 18:40
@sriram-mv sriram-mv enabled auto-merge (squash) December 16, 2022 18:57
qingchm
qingchm approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@qingchm qingchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: as a follow-up investigate the reason behind this logic and add some comment here explaining the need to include_py_files

@sriram-mv sriram-mv merged commit bea3bc0 into aws:develop Dec 16, 2022
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 16, 2022
@mndeveci
Revert "fix: hooks data imports for pyinstaller (aws#4491)"
ed0e799 
This reverts commit bea3bc0.
mndeveci added a commit that referenced this pull request Dec 17, 2022
@mndeveci
revert: remove cfn-lint integration (#4494)
42e512d 
* Revert "fix: `hooks` data imports for pyinstaller (#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (#4444)"

This reverts commit 2fd533f.
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@sriram-mv @mndeveci
fix: hooks data imports for pyinstaller (aws#4491)
8f30f8d 
- import `cfnlint` with data files, python files and package metadata
  directories.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
f5c9f44 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c3fc28b 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c24af57 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@sriram-mv @mndeveci
fix: hooks data imports for pyinstaller (aws#4491)
bf92acf 
- import `cfnlint` with data files, python files and package metadata
  directories.
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Dec 19, 2022
@mndeveci
revert: remove cfn-lint integration (aws#4494)
c7b8c56 
* Revert "fix: `hooks` data imports for pyinstaller (aws#4491)"

This reverts commit bea3bc0.

* Revert "fix: Update expected message read validate lint integration test (aws#4488)"

This reverts commit abd7c03.

* Revert "Update lint helpand output message (aws#4489)"

This reverts commit 3304955.

* Revert "fix: `pyinstaller` binaries (aws#4486)"

This reverts commit b8a939d.

* Revert "fix:  Fix validate command integration tests console output missmatch and update pyyaml version requirement (aws#4479)"

This reverts commit ce7143c.

* Revert "Adding cfn-lint as optional parameter for SAM validate command (aws#4444)"

This reverts commit 2fd533f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndeveci mndeveci mndeveci approved these changes

@lucashuy lucashuy lucashuy approved these changes

@qingchm qingchm qingchm approved these changes

Assignees
No one assigned
Labels
pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sriram-mv @mndeveci @lucashuy @qingchm