Add CodeQL GH Action #4552
Merged
Add CodeQL GH Action #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawflau
force-pushed
the
add-codeql-action
branch
from
5a0c519 to
9b22020
Compare
hnnasit
approved these changes
Jan 10, 2023
sriram-mv
reviewed
Jan 10, 2023
| @@ -201,6 +201,10 @@ def generate_thumbprint(oidc_provider_url: Optional[str]) -> Optional[str]: | |||
| # Create an IPV4 socket and use TLS for the SSL connection | |||
| address = (url_for_certificate, 443) | |||
| ctx = SSL.Context(SSL.TLS_METHOD) | |||
| ctx.set_options(SSL.OP_NO_TLSv1) | |||
There was a problem hiding this comment.
should we verify this with unit tests?
sriram-mv
previously requested changes
Jan 10, 2023
Yes, it's run on each PR. Failure of this action should prevent the PR from being merged. And the PR author should fix me. The action will also run on schedule, because existing code might be subjected to newly discovered vulnerabilities. We will get notified and also can check from the "Security" tab in the repo. |
torresxb1
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
Enable Code Scan through GH Action
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.