fix: Fix the permission errors in Windows and add back the CVE-2007-4559 Patch changes #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/local/invoke
hawflau
suggested changes
Jan 18, 2023
hawflau
approved these changes
Jan 19, 2023
mildaniel
pushed a commit
to mildaniel/aws-sam-cli
that referenced
this pull request
Jan 26, 2023
Patch changes (aws#4580) * Revert "Revert "fix: Add back the fixed CVE-2007-4559 Patch changes (aws#4539)" (aws#4560)" This reverts commit 6aab7de. * Updated extract_tarfile to include fileobj as input parameter as well * Added functional tests for file_obj kw arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4560
The CVE Security Patch changes were breaking the windows integrations tests due to a permission denied error while running --use-container for buildcmd tests. The issue was NamedTemporaryFile.name was used to open the file a second time and according to https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile, name cannot be used to open the file a second time while its still open on Windows.
The extract_tarfile function now takes in file_obj and file name as input parameters. Either option can be used to extract a tar_file.
Integration tests were run on Windows, MacOS, & Linux to confirm the new changes work. Functional tests are added to test extracting a tarfile using the file name. Integration tests that run the buildcmd with --use-container flag can be used for verifying the behavior for extracting a tarfile using fileobj.