Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix master 4462 #4601

Merged
merged 3 commits into from
Jan 21, 2023
Merged

Fix master 4462 #4601

merged 3 commits into from
Jan 21, 2023

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Jan 20, 2023

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss jfuss requested a review from a team as a code owner January 20, 2023 23:05
@jfuss jfuss requested review from moelasmar and mildaniel January 20, 2023 23:05
@jfuss jfuss changed the base branch from develop to master January 20, 2023 23:06
@hawflau
Copy link
Contributor

hawflau commented Jan 20, 2023

NOTE: Use Merge Commit instead of "Squash and merge"

@mndeveci mndeveci mentioned this pull request Jan 21, 2023
Merged
@mndeveci mndeveci merged commit 9a13aa2 into aws:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelasmar moelasmar Awaiting requested review from moelasmar moelasmar was automatically assigned from aws/serverless-application-experience-sbt

@mildaniel mildaniel Awaiting requested review from mildaniel mildaniel was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfuss @hawflau @mndeveci