Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove python3.6 support #4635

Merged
merged 8 commits into from
Feb 6, 2023
Merged

fix: remove python3.6 support #4635

merged 8 commits into from
Feb 6, 2023

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

#4512

Why is this change necessary?

python3.6 have reached its EOL December 2021 and AWS Lambda dropped support in August 2022

How does it address the issue?

By removing python3.6 from enums and also replacing in the tests. Also added into deprecated runtimes for error handling.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner January 30, 2023 23:21
@mndeveci mndeveci requested review from hawflau and lucashuy January 30, 2023 23:21
@github-actions github-actions bot added pr/internal area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke labels Jan 30, 2023
@mndeveci mndeveci mentioned this pull request Jan 30, 2023
Merged
lucashuy
lucashuy approved these changes Jan 30, 2023
View reviewed changes
samcli/commands/build/command.py Outdated Show resolved Hide resolved
hnnasit
hnnasit reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Should we also remove python3.6 from the appveyor jobs or should we do that in a separate PR? For instance appveyor-ubuntu.yml installs python3.6

@mndeveci
Copy link
Contributor Author

Q: Should we also remove python3.6 from the appveyor jobs or should we do that in a separate PR? For instance appveyor-ubuntu.yml installs python3.6

Good point, it is better to do in this PR, let me update with that

@mndeveci mndeveci mentioned this pull request Feb 6, 2023
Closed
@mndeveci mndeveci merged commit c591f28 into aws:develop Feb 6, 2023
@mndeveci mndeveci deleted the remove_python36 branch February 6, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucashuy lucashuy lucashuy approved these changes

@moelasmar moelasmar moelasmar approved these changes

@hnnasit hnnasit hnnasit approved these changes

@hawflau hawflau Awaiting requested review from hawflau hawflau was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mndeveci @lucashuy @moelasmar @hnnasit