Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only stream command output to stdout #4650

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

mildaniel
Copy link
Contributor

Since sam list is a command that can be used programmatically with the json output format, we should reserve the stdout stream to be exclusively the output of the command, similar to how sam local invoke works today.

This PR changes the warning message to use stderr instead.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner February 1, 2023 16:58
@mildaniel mildaniel enabled auto-merge (squash) February 1, 2023 17:32
@mildaniel mildaniel merged commit 64e2e4e into aws:develop Feb 1, 2023
@mildaniel mildaniel deleted the write-list-to-stderr branch February 1, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants