Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow SAM-T version update GHA to get latest tag #5154

Merged
merged 1 commit into from
May 11, 2023

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented May 11, 2023

There are two issues this patch fixes:

  1. the sed for updating the SAM-T version was flipped causing an invalid base.txt
  2. The default fetch depth is 1 causing only the latest commit to be pulled. For some reason, this causes the tag "git describe" returns nothing. With a fetch depth of 0, we get the right value.

Which issue(s) does this change fix?

none

Why is this change necessary?

See above commit message

How does it address the issue?

See above commit message

What side effects does this change have?

None

Proof it works this time :) https://github.com/jfuss/aws-sam-cli/actions/runs/4943420245/jobs/8837895491

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

There are two issues this patch fixes:
1) the sed for updating the SAM-T version was flipped causing an invalid
base.txt
2) The default fetch depth is 1 causing only the latest commit to be pulled.
For some reason, this causes the tag "git describe" returns nothing. With a
fetch depth of 0, we get the right value.
@jfuss jfuss requested a review from a team as a code owner May 11, 2023 02:58
@jfuss jfuss requested review from lucashuy and moelasmar May 11, 2023 02:58
@jfuss jfuss added this pull request to the merge queue May 11, 2023
Merged via the queue into aws:develop with commit 1adc080 May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants