feat: Add schema validation tests #5654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
To ensure the generated schema is correct, we need to test it against various config files. This will ensure that tests that should validate against the schema will validate, while tests that shouldn't validate against the schema won't.
How does it address the issue?
A new test file,
test_schema_validation.py
has been created to validate various config files against the generated schema. In addition, atestdata
folder has been added, with various hand-written config files to test each command, as well as prevent invalid schemas.What side effects does this change have?
New tests have been added, to test that config files will and won't validate against the schema.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.